Skip to content

Conversation

@Sam-Mear
Copy link

Description (*)

Fixes #36660
Adds public property support to DataObjectProcessor output serialization and snake_case constructor hydration in ServiceInputProcessor, enabling promoted/readonly DTOs for message queue payloads. Includes unit/integration tests and docs for getter vs public property precedence.

Example DTO:

class QueueMessage
{
    public function __construct(
        public readonly int $salesOrderId
    ) {}
}

Fixed Issues (if relevant)

  1. Fixes magento/magento2#36660

Manual testing scenarios (*)

  1. Run unit tests:
    • ServiceInputProcessorTest.php
    • DataObjectProcessorTest.php
  2. Run integration test:
    • MessageEncoderTest.php
  3. Publish/consume a message using an object_interface topic with a DTO using readonly promoted properties and verify JSON payload includes the property and consumer receives hydrated values.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 22, 2026

Hi @Sam-Mear. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Sam-Mear
Copy link
Author

@magento run all tests

@Sam-Mear
Copy link
Author

@magento run all tests

@Sam-Mear
Copy link
Author

@magento run Static Tests,WebAPI Tests,Unit Tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 27, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Add support for plain objects with promoted properties in message queue communication

2 participants